Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xrefs for remote connections over TRAMP #432

Merged
merged 3 commits into from
May 14, 2024
Merged

Fix xrefs for remote connections over TRAMP #432

merged 3 commits into from
May 14, 2024

Conversation

gsingh93
Copy link
Contributor

Haven't done much extensive testing with this, but it fixes #413 for me.

@gsingh93 gsingh93 mentioned this pull request Mar 30, 2023
Closed
@gsingh93
Copy link
Contributor Author

@jacktasia would you be able to take a look at this to see if it's the proper fix?

1 similar comment
@mrunhap
Copy link

mrunhap commented May 14, 2024

@jacktasia would you be able to take a look at this to see if it's the proper fix?

jacktasia
jacktasia approved these changes May 14, 2024
View reviewed changes
Copy link
Owner

@jacktasia jacktasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for taking forever!

@jacktasia jacktasia merged commit 3c2ab8d into jacktasia:master May 14, 2024
5 checks passed
@prashantvithani
Copy link

prashantvithani commented Jun 24, 2024 •
edited
Loading

@jacktasia This patch has actually broken dumb-jump-go. It blindly adds tramp-path-prefix to a relative path, which is already added dumb-jump--result-follow as part of default-directory (default directory is ssh:host:path/to/dir and relative path in the results is always corresponding to default-directory.

Reverting this patch locally fixes it.

jacktasia added a commit that referenced this pull request Jun 25, 2024
@jacktasia
Revert "Fix xrefs for remote connections over TRAMP (#432)"
8365e0e 
This reverts commit 3c2ab8d.
@jacktasia jacktasia mentioned this pull request Jun 25, 2024
Merged
jacktasia added a commit that referenced this pull request Jun 25, 2024
@jacktasia
Revert "Fix xrefs for remote connections over TRAMP (#432)" (#450)
cd65a74 
This reverts commit 3c2ab8d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacktasia jacktasia jacktasia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xref jump fails on Tramp opened files
4 participants
@gsingh93 @mrunhap @prashantvithani @jacktasia